Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { schemaVersionMiddleware } from './middlewares/schema-version.middleware
import { requestLoggerMiddleware } from './middlewares/request-logger.middleware';
import { requestContextMiddleware } from './middlewares/request-context.middleware';
import { requestEntryLoggerMiddleware } from './middlewares/request-entry-logger.middleware';
import { requestCompletionLoggerMiddleware } from './middlewares/request-completion-logger.middleware';
import { requestCompletionLoggerMiddleware, slowRequestLoggerMiddleware } from './middlewares/request-completion-logger.middleware';
import { sessionActivityMiddleware } from './middlewares/session-activity.middleware';
import { bodyParseErrorMiddleware } from './middlewares/body-parse-error.middleware';
import { routeBodySizeLimit } from './middlewares/body-size-limit.middleware';
Expand All @@ -47,6 +47,7 @@ app.use(apiVersionMiddleware);
app.use(schemaVersionMiddleware);
app.use(requestEntryLoggerMiddleware);
app.use(requestCompletionLoggerMiddleware);
app.use(slowRequestLoggerMiddleware);
// Session activity logging (#1035): registers a res.on('finish') listener
// so it can read req.user after route-level auth guards have run. Mount
// position only needs to be before the routers.
Expand Down
2 changes: 2 additions & 0 deletions src/config.schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,8 @@ export const envSchema = z
BADGE_TOP_TRADER_MAX_RANK: z.coerce.number().int().positive().default(10),
// Max mint attempts before a transient failure is treated as terminal.
BADGE_MINT_MAX_ATTEMPTS: z.coerce.number().int().positive().default(3),
// Slow request threshold (#754): warn-level log for requests exceeding this duration
SLOW_REQUEST_THRESHOLD_MS: z.coerce.number().int().positive().default(2000),
})
.superRefine((data, ctx) => {
if (data.MODE === 'production' && data.STELLAR_NETWORK === 'testnet') {
Expand Down
43 changes: 43 additions & 0 deletions src/middlewares/request-completion-logger.middleware.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
import { Request, Response, NextFunction } from 'express';
import { logger } from '../utils/logger.utils';
import { envConfig } from '../config';

interface AuthenticatedRequest extends Request {
user?: {
wallet: string;
};
}

// Log request outcome after the response has been fully sent.
//
Expand Down Expand Up @@ -72,3 +79,39 @@ export const requestCompletionLoggerMiddleware = (

next();
};

export const slowRequestLoggerMiddleware = (
req: AuthenticatedRequest,
res: Response,
next: NextFunction
): void => {
const startTime = process.hrtime();
let logged = false;

// Ensure we log once even if multiple events fire.
const logOnce = () => {
if (logged) return;
logged = true;

const diff = process.hrtime(startTime);
const durationMs = diff[0] * 1e3 + diff[1] * 1e-6;

if (durationMs >= envConfig.SLOW_REQUEST_THRESHOLD_MS) {
const wallet = req.user?.wallet;
const payload = {
method: req.method,
path: req.path,
status_code: res.statusCode,
duration_ms: Math.round(durationMs),
...(wallet ? { wallet } : {}),
slow_threshold_ms: envConfig.SLOW_REQUEST_THRESHOLD_MS,
};
logger.warn(payload, 'Slow request detected');
}
};

res.once('finish', logOnce);
res.once('close', logOnce);

next();
};
Loading