Repository navigation
Add SSH transport configuration - #13
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f93be443b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
plajjan
force-pushed
the
transport-config
branch
from
August 27, 2026 20:15
f93be44 to
224f176
Compare
SSH negotiation relied entirely on libssh defaults, while key handling still exposed filesystem paths. Instead, expose exhaustive typed algorithm catalogs and a shared TransportConfig for client and server negotiation, compression, rekeying, and RSA limits. Accept private keys, host keys, certificates, and known_hosts data as in-memory values, including ordered multiple-key authentication. Keep connection and credential arguments directly on Client and Server, and verify the catalogs against the bundled libssh tables.
plajjan
force-pushed
the
transport-config
branch
from
August 27, 2026 21:34
224f176 to
7058e78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH negotiation relied entirely on libssh defaults, while key handling still exposed filesystem paths.
Instead, expose exhaustive typed algorithm catalogs and a shared TransportConfig for client and server negotiation, compression, rekeying, and RSA limits. Accept private keys, host keys, certificates, and known_hosts data as in-memory values, including ordered multiple-key authentication.
Keep connection and credential arguments directly on Client and Server, and verify the catalogs against the bundled libssh tables.