Repository navigation
Conversation
Zig 0.17 removed conversion of lazy paths to strings. Pass the toolchain and zlib header paths as path options so Zig keeps their dependency information. The internal libssh sha1 helper collides with BSDNT when linking Acton programs. Rename it within the wrapper's C build. Pin the compatible zlib wrapper so its configuration header builds with Zig 0.17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the toolchain and zlib header paths as Zig path options. Rename libssh's internal SHA1 helper to avoid a collision with the Acton runtime, and pin the zlib wrapper compatible with Zig 0.17.