Repository navigation
Use env.process and env.vars - #19
Merged
Merged
Conversation
The interop tests start ssh, sshd and their helper commands through env.process instead of a process.ProcessCap made from env.cap. The _Cmd helper actor takes the EnvProcess as its first parameter, and the process callbacks take the builtin Process. Every spawn result is used, so a test still waits until its child has started, as constructing a process.Process did. The example client and the interop server read HOME and ACTON_SSH_AUTH_KEY through env.vars.getenv(). There is no change to the ssh library itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acton now gives the root actor its services through Env: env.process for child processes, env.vars for environment variables and env.stdio for stdin and output (actonlang/acton#2768). This moves acton-ssh to them.