This repository was archived by the owner on Oct 28, 2026. It is now read-only.
Repository navigation
fix(test): stabilize upload and animation checks - #341
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main browser CI exposed two fixture races: attachment handoff compared selected-file order with concurrent upload completion, and a wallet screenshot wait could reject when CSS replaced an animation. Force the second selected file to finish first and verify the handoff retains selection order, stays disabled while uploading and makes no signed or scheduled writes. Wait for the current finite animations without suppressing errors or expanding timeouts.
Clarify DAU's pending message when source coverage has gaps: a complete 24-hour count needs a whole gap-free window. The existing browser case verifies the figure and comparison remain absent instead of promising a count at a start-time estimate.
Validation: Rust native/Wasm checks and licenses (767 tests), Node platform checks (24), a canceled/replaced-animation oracle, all three affected suites (46 passed, one declared skip), the full static selection (20 passed, 19 declared skips) and isolated smoothness (70 passed, two declared skips). The database module's 17-test result is reused only for identical source inputs. All 1,023 source cases, declared skips, performance budgets and workflow triggers remain intact. New normal PR and main checks must pass cleanly; the earlier main run remains rejected. No module rollout, tag or formal release.