Repository navigation
chore(deps): update suzuki-shunsuke/pinact-action action to v3.1.0 - #150
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR contains the following updates:
v3.0.0→v3.1.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
suzuki-shunsuke/pinact-action
v3.1.0Compare Source
Issues | Pull Requests | suzuki-shunsuke/pinact-action@v3.0.0...v3.1.0 | Base revision
This release includes all changes in v3.0.1.
Features
#1217 Sign JSON Web Tokens with AWS KMS
A GitHub App private key stored in GitHub Secrets never expires, and anyone who obtains it can generate access tokens as long as the key stays registered.
You can now keep the private key in AWS KMS instead. The key can never be exported, and only the JSON Web Token signing is delegated to KMS.
New inputs:
client_id(new) orapp_idsecurefix_client_id(new) orsecurefix_app_idaws_kms_key_idsecurefix_aws_kms_key_idaws_role_to_assumesecurefix_aws_role_to_assumeaws_regionsecurefix_aws_regionclient_idandsecurefix_client_idcan be used instead ofapp_idandsecurefix_app_id. GitHub recommends the Client ID. When both are set, the Client ID takes precedence.aws_role_to_assumeassumes the IAM role with the GitHub OIDC token inside the action, so the AWS credentials are never exported to later steps of the job. The job needs the permissionid-token: write. If it's not set, the standard AWS credential environment variables are used, soaws-actions/configure-aws-credentialsalso works.securefix_role and region fall back to the unprefixed ones.Existing workflows using
app_idandapp_private_keyneed no change.Fixes
#1227 Install pinact when the caller has no aqua configuration
In a repository without its own aqua configuration, the action failed before running pinact:
The action's bundled aqua configuration wasn't found correctly, so the action only worked when the caller's repository had an aqua configuration to fall back to.
This has been broken since the action was rewritten in JavaScript (#838).
Behavior change
If
app_private_keyoraws_kms_key_idis set withoutclient_idorapp_id, the action now fails with an error.Previously it silently ignored the private key and used
default_github_token.Others
v3.0.1Compare Source
Fixes
#1183 Fail the step when pinact errors in
skip_push+reviewmodePreviously, when
skip_pushandreviewwere enabled, pinact's exit code was ignored and the step's result was decided entirely by reviewdog.If pinact stopped part way through (e.g. a GitHub API error), reviewdog received partial or empty results and the step passed even though nothing was verified.
Now the step fails when pinact exits with 3 or above.
Violations (exit codes 1 and 2) are still reported by reviewdog and governed by
reviewdog_fail_levelas before.reviewdog still runs before the step fails, so the findings pinact did produce are posted to the pull request.
#1181 Report the pinact failure reason based on its exit code
The error message now tells why pinact failed instead of a fixed
GitHub Actions aren't pinned.orpinact run failed:GitHub Actions aren't pinned.pinact found problems that it can't fix automatically.pinact failed due to a GitHub API error or an internal error.pinact failed with an unexpected exit code N.Only the messages changed. The set of runs that fail is the same as before.
Others
undici@5.29.0from dependencies.Configuration
📅 Schedule: (in timezone Europe/Berlin)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.