Skip to content

Repair five regressions found in the open PR review #435

Description

@airmang

The open-PR review found five reproducible regressions that need follow-up before merging the affected branches:

The fixes will include regression tests for refusal without mutation, preserve the existing Hancom-saved fixture checks, and propagate into the affected stacked PRs. First-paragraph live Hancom rendering is not claimed by these structural checks.

Repair status

The fixes have been pushed to #397, #416–#421, #428 and #430–#433 without rewriting branch history. Each dependent PR contains the same repair commits.

  • Row-only splits now require an exact anchor and preserve the document on refusal.
  • Native-object, field, bookmark and linked-reference content cloning fails closed; blank insertion keeps the original objects. XML quoting/spacing variants cannot bypass the guard. Native identity remapping remains unsupported.
  • Picture HWPUNIT values are validated before coercion and before storing images or runs.
  • Release action-pin expectations match the updated workflow, with all 56 safety tests passing locally.
  • First-paragraph column definitions precede text while preserving the run formatting, including after save/reopen. Live Hancom rendering of this case is still unverified.

Targeted regression tests, static/type checks, and a clean installed-wheel smoke test pass. The legacy public-form row test now separates text-row cloning from logo-row refusal, with an explicit unchanged-document assertion. The final combined integration suite passes: 6,541 passed, 19 skipped, 1 known xfail, with 89.87% coverage (80% required). Current GitHub CI is still running/queued; no final remote-CI success or merge is claimed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions