Describe round trip: delete close page, $[%…%] returns, navigation-list items (#950)

[ako]

Closes #950

All three items are fixed. Each is proven by describe → check → exec → describe, with the stored value compared and not only the re-described text.

1. delete close page lost ClosePage on write (silent)

• buildClientActionV3Base's delete case now copies action.ClosePage. The visitor sets it and the writer writes it, but the builder dropped it.
• Audit of every page-action case:
  • save and cancel already copied ClosePage.
  • The with (…) settings (confirmation, progress, DisabledDuringExecution) go through applyActionSettings, which is generic.
  • No other flag that the visitor sets is dropped.
• Describe prints every ClosePage it reads.
• Two values are hard-coded and cannot be written in MDL. Both are listed under follow-ups.

2. return $[%CurrentUser%];

• Describe used to add $ to anything that had none of the characters +'"(). That also turned return if … then … else … into return $if …, which hit two TestApp WorkflowCommons microflows.
• It now adds $ only to a bare name with an optional /path, which is the shape a legacy writer stored without the $.
• The other places in describe that add $ do so to variable-name fields, not to expressions. They are safe and unchanged.

3. Navigation-list items

• Action: extractNavigationListItemAction now uses the shared client-action renderer, so actions print as show page M.P, call microflow …, sign out and so on.
• Unnamed items: fixing the parse error exposed the next failure. Studio Pro leaves items unnamed, and exec refused that with "item inside navigationlist requires a name". Exec now accepts an unnamed item, and describe prints it as item (…).
• Writer: for an unnamed item, the writer now leaves out the Name key and writes a null ConditionalVisibilitySettings. This matches all 6 Studio Pro-authored items in TestApp. Before this, a describe → exec of Rules.Entity_Menu still rewrote the snippet.
• mx check (11.14.0) on a TestApp copy with unnamed items written by exec: 0 errors.

Harness

• New mdl/roundtrip/describe_reparse_950_test.go (PedApp). For each of the three cases it runs describe → checkReferences → exec → describe, checks that nothing was written, and checks the stored ClosePage per button. A plain delete button is the control.
• Struck from the TestApp allowlist:
  • snippet Rules.Entity_Menu
  • microflow WorkflowCommons.SUB_Workflow_AverageHandlingTime
  • microflow WorkflowCommons.SUB_WorkflowTask_AverageHandlingTime

Test plan

• make build
• go test ./mdl/executor/ ./mdl/backend/modelsdk/ ./mdl/visitor/ ./cmd/mxcli/: ok
• go test -tags integration ./mdl/roundtrip/ -run 'TestTestAppRoundTrip$|TestPedAppRoundTrip$|DescribeUsesCanonicalSpellings|DescribeIsValid|TestDescribeReExecutes_950|Pluggable': ok
• make lint (includes check-conformance): ok
• make check-findings: ok
• End to end with the CLI on fresh copies:
  • jts App: delete close page → bson dump shows ClosePage true on that button and false on the plain delete button; describe → exec gives "Unchanged".
  • TestApp: describe snippet Rules.Entity_Menu → check --references → exec → describe gives identical output and "Unchanged".
  • mxcli docker check on the result: 0 errors.

Revert checks. Each fix was removed in turn and the tests were run again:

Fix removed	What failed
Builder ClosePage copy	Harness: as created, bDelClose stores ClosePage=false. Unit test: "describe printed delete close page, which builds ClosePage=false".
Return-value $ rule	Harness: describe has no return [%CurrentUser%];. Unit test: $[%CurrentUser%] does not parse (token recognition error at: '$[').
Shared renderer for nav items	Harness and unit test: described show_page 'Rules.BusinessRule_Overview'.
Accepting unnamed items	Harness: "item inside navigationlist requires a name".
Omitting Name on unnamed items in the writer	TestTestAppRoundTrip/snippet_Rules.Entity_Menu reports Items[n]/Name: added.
Null visibility slot	Writer unit test: ConditionalVisibilitySettings missing.

Follow-ups (not changed here; each needs a syntax decision)

• complete task: the builder always writes ClosePage: true and Commit: true, and describe prints neither. A Studio Pro outcome button with either one off would be flipped by a describe → exec. All 4 such buttons in TestApp have both true, so this is latent today.
• close page / show page / create object: the number of pages to close (NumberOfPagesToClose / NumberOfPagesToClose2) is written as "" and has no MDL form. All stored values in TestApp are "", so this is also latent.

🤖 Generated with Claude Code