Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long prompts can make the mock engine skip a matching judge or keyword branch: with
pipefail,grep -qexits early and the upstreamechocan receive SIGPIPE. This can leave the correction-retry test recording onlycorrectioninstead ofinitial\ncorrection\n, as observed in main CI run 40647801009. Retrying that run passed and restored the README CI badge.Replace the mock's detection pipelines with Bash string matching, preserving case-sensitive judge detection and case-insensitive keyword responses. Add eight 1 MiB prompt regression cases covering initial/correction judge responses and every keyword branch; the old script was reproduced skipping the initial judge branch.
Validation:
make fmtandmake verify(zero issues; pinned tools rebuilt with Go 1.26.0).make testthrough the environment's existing child-reaping wrapper, required because this container's PID 1 does not reap orphan processes; all tests pass.make e2eand the focused correction-retry/long-prompt tests pass.bash -nandgit diff --checkpass.