Repository navigation
fix: form-render html widget crash when value not found in options - #1743
Open
jevonsflash wants to merge 1 commit into
Open
jevonsflash wants to merge 1 commit into
jevonsflash wants to merge 1 commit into
Conversation
options.find() may return undefined, accessing item.label directly throws TypeError. Use optional chaining like the single-value branch already does.
|
@jevonsflash is attempting to deploy a commit to the Faberon Team on Vercel. A member of the Team first needs to authorize it. |
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In form-render's
htmldisplay widget, when the schema value is an array and one of its items no longer exists inoptions(e.g. options were changed after the form data was saved),options.find()returnsundefinedanditem.labelthrowsTypeError: Cannot read properties of undefined (reading 'label'), crashing the whole form render.Fix
Use optional chaining in the array branch, consistent with the single-value branch right above it which already uses
item?.label:When an item is not found in options, it is simply skipped in the display string instead of crashing the render.
Impact
Only packages/form-render/src/widgets/fields/html/index.tsx