Repository navigation
PostgreSQL: Validate session transaction characteristics - #8
Merged
amaksimo merged 1 commit intoOct 15, 2026
Merged
Conversation
Require SESSION and a transaction mode for SET CHARACTERISTICS. Preserve transaction modes in the session AST and bump sqlparser-dsql to 0.62.11.
amaksimo
marked this pull request as ready for review
October 15, 2026 20:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
dsql-lintrelies on the session transaction AST to distinguish supportedSET SESSION CHARACTERISTICSforms from unsupported transaction settings.Accepting another scope as a session transaction can make malformed input pass
that validation.
What
SESSIONand at least one transaction mode forSET ... CHARACTERISTICS AS TRANSACTION.sqlparser-dsqlto 0.62.11 for the linter update.Testing
and SQL round trip.
crate, and warning-denying Rustdoc pass.
thumbv6m-none-eabino-std check and publish dry-run pass.References