Skip to content

bugfix/rename_allplugins - #279

Open
amd-ansonyim wants to merge 3 commits into
developmentfrom
rename_allplugins
Open

bugfix/rename_allplugins#279
amd-ansonyim wants to merge 3 commits into
developmentfrom
rename_allplugins

Conversation

@amd-ansonyim

Copy link
Copy Markdown
Collaborator

Summary

  • updated AllPlugins class to AllIbPlugins
  • fix unit tests

Test plan

  • pytest test/unit
  • pytest test/functional (if applicable)
  • pre-commit run --all-files

Checklist

  • Added/updated tests (or explained why not)
  • Updated docs/README if behavior changed
  • No secrets or credentials committed

@github-actions github-actions Bot added documentation Improvements or additions to documentation tests labels Sep 1, 2026

@alexandraBara alexandraBara left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your logic on picking up the plugins from /nodescraper/plugins/inband ONLY needs to be updated bc the config show OOB/ServiceabilityPlugins as well:

(venv) alexbara@ausalexbara02:~/node-scraper_public$ node-scraper describe config AllIbPlugins
  2026-09-04 07:05:14 CDT       INFO               nodescraper | Log path: ./scraper_logs_ausalexbara02_2026_09_04-07_05_14_AM
  2026-09-04 07:05:14 CDT       INFO               nodescraper | Config Name: AllIbPlugins
Description: Run all registered in-band plugins with default arguments.
Plugins:
        AmdSmiPlugin
        BiosPlugin
        CmdlinePlugin
        DeviceEnumerationPlugin
        DimmPlugin
        DkmsPlugin
        DmesgPlugin
        FabricsPlugin
        GenericCollectionPlugin
        JournalPlugin
        KernelModulePlugin
        KernelPlugin
        MemoryPlugin
        **Mi4xxServiceabilityPlugin**
        NetworkPlugin
        NicPlugin
        NvmePlugin
        **OobBmcArchivePlugin
        OobGenericCollectionPlugin**
        OsPlugin
        PackagePlugin
        PciePlugin
        ProcessPlugin
        RdmaPlugin
        **RedfishEndpointPlugin
        RedfishOemDiagPlugin**
        RegexSearchPlugin
        RocmPlugin
        ScaleOutAristaPlugin
        ScaleOutDellPlugin
        **ServiceabilityPluginBase
        ServiceabilityPluginMI3XX**
        StoragePlugin
        SysSettingsPlugin
        SysctlPlugin
        SyslogPlugin
        UptimePlugin

it should ignore plugins defined in /oob and /serviceability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants