bugfix/rename_allplugins - #279
Open
amd-ansonyim wants to merge 3 commits into
Open
Conversation
alexandraBara
requested changes
Sep 4, 2026
alexandraBara
left a comment
Collaborator
There was a problem hiding this comment.
Your logic on picking up the plugins from /nodescraper/plugins/inband ONLY needs to be updated bc the config show OOB/ServiceabilityPlugins as well:
(venv) alexbara@ausalexbara02:~/node-scraper_public$ node-scraper describe config AllIbPlugins
2026-09-04 07:05:14 CDT INFO nodescraper | Log path: ./scraper_logs_ausalexbara02_2026_09_04-07_05_14_AM
2026-09-04 07:05:14 CDT INFO nodescraper | Config Name: AllIbPlugins
Description: Run all registered in-band plugins with default arguments.
Plugins:
AmdSmiPlugin
BiosPlugin
CmdlinePlugin
DeviceEnumerationPlugin
DimmPlugin
DkmsPlugin
DmesgPlugin
FabricsPlugin
GenericCollectionPlugin
JournalPlugin
KernelModulePlugin
KernelPlugin
MemoryPlugin
**Mi4xxServiceabilityPlugin**
NetworkPlugin
NicPlugin
NvmePlugin
**OobBmcArchivePlugin
OobGenericCollectionPlugin**
OsPlugin
PackagePlugin
PciePlugin
ProcessPlugin
RdmaPlugin
**RedfishEndpointPlugin
RedfishOemDiagPlugin**
RegexSearchPlugin
RocmPlugin
ScaleOutAristaPlugin
ScaleOutDellPlugin
**ServiceabilityPluginBase
ServiceabilityPluginMI3XX**
StoragePlugin
SysSettingsPlugin
SysctlPlugin
SyslogPlugin
UptimePlugin
it should ignore plugins defined in /oob and /serviceability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pytest test/unitpytest test/functional(if applicable)pre-commit run --all-filesChecklist