Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7cf7e7b27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect(Object.keys(analysis).sort()).toEqual(['edition','pages','panels']); | ||
| for (const note of Object.values(analysis.panels) as any[]) { |
There was a problem hiding this comment.
The exact-field allowlist covers the document root, panel notes, and eye-path points, but skips every value in analysis.pages; validateCompanion likewise only checks that purpose and compositionReason exist. Consequently, a regenerated editorial file containing an additional page-level field such as draft, generationMetadata, or another private working field would pass these publication checks and be copied verbatim into the public JSON. Assert that each page analysis has exactly the two intended keys, as is already done for panel notes and eye-path points.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
The Occasion now has a public editorial companion beside its library card and in the comic toolbar. Readers can select any of the 95 pictures across 45 pages, inspect its copy or silence rationale and predicted reader inference, and turn on an optional eye-path overlay. Eye paths start off and are explicitly described as editorial hypotheses.
The companion reuses the published artwork, crops and separate lettering. It links back to the selected comic picture; page navigation and the toolbar collapse independently. A field allowlist publishes only the requested analysis, excluding private notebook notes, prompts and provenance records. Existing prose-book behavior is unchanged.
Validation
The large JSON diff is the generated, allowlisted analysis for the existing 95 pictures; no image bytes change. Rollback is a revert of this scoped publication change, with no user-data migration. Required Codex review and CI must finish before merge.