Repository navigation
Show disabled installed app updates like other apps - #184
Merged
Merged
Conversation
Disabled installed apps with updates now appear in the New versions tab and the New section, and keep the recent highlight. Only the version text without upgrade arrow and the disabled installed icon differ. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e2311e25-aadb-4d18-a339-afbfb492178e
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Focused tests do not independently cover the newly ungated update-status and recent-flag paths.
2 open findings
What changed in this PR
Updates disabled installed apps to participate in update and recent-item UI while retaining disabled-specific presentation.
Changes:
- Includes disabled apps in updatable filtering and update sections.
- Preserves recent/new highlighting for disabled apps.
- Updates paging and state tests for the revised behavior.
| File | Description |
|---|---|
AppListFilter.kt |
Includes disabled installed apps in Updatable results. |
WatchListPagingSource.kt |
Ranks disabled updated/recent apps normally. |
SectionHeaderFactory.kt |
Groups disabled apps into New/Recently Discovered sections. |
AppItemState.kt |
Preserves recent/new indicators when disabled. |
WatchListPagingSourceRoomTest.kt |
Updates paging expectations. |
AppItemStateTest.kt |
Updates disabled-app highlight expectations. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e2311e25-aadb-4d18-a339-afbfb492178e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the disabled-app list filtering introduced in #167 so installed-but-disabled apps with updates behave like other apps.
Changes
AppListFilter.Updatable: disabled apps with updates are included in the New versions tab.WatchListPagingSource.sectionRank/SectionHeaderFactory: disabled updated apps rank and group under New (and recently discovered) like other apps.AppItemState: disabled apps keep the recent/new highlight.Kept
Testing
:app:testDebugUnitTestpasses; updated tests that asserted the old filtering behavior.