Repository navigation
fix(venn): avoid broken fmin package-root exports - #3894
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
fmin@0.0.4's package root resolves to a UMD entry without named exports, breaking Venn layout builds and CommonJS execution. Keep the required helper subset local with its BSD attribution and cover the synthetic overlap and constrained-layout paths. Related: closed, unmerged PR antvis#3888.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need
Restore Venn layout imports in the docs bundle and CommonJS build.
Updating reason
fmin@0.0.4points its package root at a UMD file that exposes no named exports to the docs bundler. The existing Venn import also produced an unusable CommonJS layout at runtime. Replace that import with the small helper subset Venn needs, retain the upstream BSD license notice, and cover overlap bisection plus constrained layout with deterministic synthetic data. Related prior report: closed, unmerged PR #3888.Related testing
npm run lint: passed; four pre-existing unused-variable warnings remain in unrelated tests.npm run build: passed.cd site && npm run buildon Windows no longer reports thefminnamed-export errors; Dumi then fails creatingdist/:language/examplesbecause:is invalid in Windows paths. No deployment or CI status was queried.User tips
No public API or chart output format changed.