Repository navigation
Fix byte comparisons for subsequences with nonzero offsets - #1141
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Generated-by: OpenAI Codex (GPT-6.1-sol)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bytes.compareToUnchecked()stops its comparison loop atminLen, even though its index starts at the backing-array offset. For nonzero-offset subsequences this compares too few bytes, potentially treating different values as equal and producing inconsistent ordering.Include the offset in the loop end bound so all overlapping bytes are compared. Add regression coverage for ordering in both directions, equality, and byte-array comparisons with and without an offset.
Validation:
BytesTest: 22 tests, one regression failure. Fixed: all 22 pass.mvn verifyas requested by CONTRIBUTING.md. With task-local Java 21, API (89 tests), Accumulo (47 tests), and Core (20 tests) passed. The build stopped in Command: seven errors caused byInvalidPathExceptionon resource paths beginning/D:/...on Windows. Mini/integration tests were not reached.git diff --checkpass.AI-assisted with OpenAI Codex (GPT-6.1-sol).