Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The APISIX chart pins ingress controller chart 1.3.0, which explicitly renders
listener_port_match_mode: auto. That overrides the controller 2.2.0 default ofoff. When a Gateway listener uses port 80 but the Service forwards to APISIX on port 9080, listener-port predicates can prevent routes from matching.Set
ingress-controller.config.listenerPortMatchModetooffin the umbrella chart. Explicitautoandexplicitoverrides remain supported. The change works with the currently published dependency, without waiting for a controller chart release. Chart version is bumped to 2.18.3 and the upgrade behavior is documented.Related to #1001 and #1002. The latter updates the standalone controller chart; this PR covers the umbrella chart independently.
Validation:
off,auto, andexplicitvalues. The test fails on the current master default and passes with this change.helm lint charts/apisixpasses.ct lint --validate-maintainers=false --charts charts/apisix --skip-helm-dependenciespasses using the CI imagequay.io/helmpack/chart-testing:v3.13.0, after building dependencies.helm-docs v1.11.0regeneration is idempotent; shell syntax, workflow YAML parsing, andgit diff --checkpass.No live-cluster routing test was run for this values-only change.