Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1743
Rationale for this change
Native ORC reads use the global batch size. Reducing it to handle large String/Binary values also affects other native operators.
What changes are included in this PR?
Add
spark.auron.orc.batchSizeand pass it to the ORC reader through the existing JNI configuration path. The value must be positive and defaults tospark.auron.batchSize.Add regression coverage for configuration validation, ORC batch boundaries, and unchanged Parquet batching. Document the new setting.
Are there any user-facing changes?
Users can configure native ORC reader batches independently at application startup. Existing defaults are preserved; downstream operators may still coalesce batches.
How was this patch tested?
env RUSTFLAGS='-C target-cpu=native' cargo test --profile pre --locked -p datafusion-ext-plans orc_exec::tests../build/mvn -Ppre -Pspark-3.5 -Pscala-2.12 -pl spark-extension-shims-spark -DskipBuildNative '-Dsuites=org.apache.auron.AuronQuerySuite ORC reader batch size' test../build/mvn -Ppre -Pspark-4.0 -Pscala-2.13 -pl spark-extension-shims-spark -DskipBuildNative '-Dsuites=org.apache.auron.AuronQuerySuite ORC reader batch size' test../dev/reformat --check.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-6)
ASF guidance: https://www.apache.org/legal/generative-tooling.html