Repository navigation
Conversation
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
October 16, 2026 12:42
`os.path.split()` splits the path into a `(head, tail)` pair, not into a list of all path segments. Use `pathlib` to iterate over all path segments and also reject absolute paths. `_ensure_real_directory()` is only called from `_process_list()`, though, where it's separately called for each level in the hierarchy. Due to this, each path segment was already checked and thus, the previous bug didn't cause any issues.
juergbi
force-pushed
the
jbilleter/ensure_real_directory
branch
from
October 16, 2026 14:48
390a570 to
b117ed8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.path.split()splits the path into a(head, tail)pair, not into a list of all path segments.Use
pathlibto iterate over all path segments and also reject absolute paths._ensure_real_directory()is only called from_process_list(), though, where it's separately called for each level in the hierarchy. Due to this, each path segment was already checked and thus, the previous bug didn't cause any issues.