Skip to content

cascache: Validate hash before using it for a filesystem path #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juergbi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cascache: Validate hash before using it for a filesystem path #2203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/buildstream/_cas/cascache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import itertools
import os
import re
import stat
import contextlib
import time
Expand All @@ -41,6 +42,10 @@
_CACHE_USAGE_REFRESH = 5


# Constant for SHA-256 validation (64 hexadecimal digits)
_HASH_REGEX = re.compile(r"[0-9a-f]{64}")


class CASLogLevel(FastEnum):
WARNING = "warning"
INFO = "info"
Expand Down Expand Up @@ -323,6 +328,9 @@ def pull_tree(self, remote, digest):
# (str): The path of the object
#
def objpath(self, digest):
if not _HASH_REGEX.fullmatch(digest.hash):
raise ValueError(f"Invalid hash: `{digest.hash}`")

return os.path.join(self.casdir, "objects", digest.hash[:2], digest.hash[2:])

# open():
Expand Down
Loading