Repository navigation
cascache: Fixes for checkout() - #2204
Merged
Merged
Conversation
`bst artifact checkout` verifies that the destination is empty. However, `bst artifact checkout --force` allows checkout to a non-empty directory. Let's not blindly follow pre-existing directory symlinks even in that case.
`bst artifact checkout --force` intentionally replaces existing files. The same should apply to symlinks. Without `--force`, it should not be possible to hit that code path.
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
October 16, 2026 13:45
BenjaminSchubert
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bst artifact checkout --forceallows checkout to a non-empty directory. Make sure that this works as expected with symlinks.