Skip to content

_elementsources.py: Don't follow symlinks in init_workspace() #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juergbi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

_elementsources.py: Don't follow symlinks in init_workspace() #2205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/buildstream/_elementsources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from contextlib import contextmanager
from typing import TYPE_CHECKING, Iterator

from . import _cachekey
from . import _cachekey, utils
from ._exceptions import SkipJob
from ._context import Context
from ._protos.buildstream.v2 import source_pb2
Expand Down Expand Up @@ -191,12 +191,12 @@ def push(self):
def init_workspace(self, directory: str):
for source in self.sources():
if source._directory:
srcdir = os.path.join(directory, source._directory)
subdir = source._directory.lstrip(os.path.sep)
utils._ensure_real_directory(directory, subdir)
srcdir = os.path.join(directory, subdir)
else:
srcdir = directory

os.makedirs(srcdir, exist_ok=True)

source._init_workspace(srcdir)

# fetch():
Expand Down
Loading