[CLI-300] Parse -opt=value for multi-character short options - #440
Draft
tanvir-ux wants to merge 1 commit into
Draft
[CLI-300] Parse -opt=value for multi-character short options#440tanvir-ux wants to merge 1 commit into
tanvir-ux wants to merge 1 commit into
Conversation
DefaultParser.handleShortAndLongOption only treated the left-hand side of
an equals token as a short option when it was a single character, so a
multi-character short option such as Option.builder("foo").hasArg() failed
on "-foo=bar" with UnrecognizedOptionException. Match short options with
Options.hasShortOption instead, which already works for the non-equals path.
garydgregory
marked this pull request as draft
August 27, 2026 14:16
Member
|
A short option is, IIRC, by definition of length one, and allows for grouping |
Author
|
Thanks. POSIX short options are one character, agreed. Commons CLI currently still documents multi-character |
Member
|
I'll have to review the issue again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.apache.org/jira/browse/CLI-300
Summary
DefaultParser.handleShortAndLongOptiononly treated the left-hand side of an equals token as a short option when it was a single character (opt.length() == 1). A multi-character short option such asOption.builder("foo").hasArg()therefore failed on-foo=barwithUnrecognizedOptionException, while-f=barand-foo baralready worked.Change
Use
Options.hasShortOption(opt)for the equals path, matching the non-equals short-option lookup already used a few lines above. Single-character short options, Java-property style (-Dkey=value), and long options with a single dash (-foo=barwithlongOpt("foo")) keep the same behavior.Tests
DefaultParserTest#testMultiCharShortOptionWithEqual— regression for the reported caseDefaultParserTest#testMultiCharShortOptionWithoutEqual— paired non-equals pathFull
mvnbuild succeeds locallyRead the contribution guidelines for this project.
Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Assisted with drafting the patch and PR text; change and tests authored and verified locally as Md Tanvir Alam.
Run a successful build using the default Maven goal with
mvn; that'smvnon the command line by itself.Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.