Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the wrapped-class validation change.
No open issues 🎉
What changed in this PR
Fixes DAEMON-479 by allowing jsvc -check @ClassName to validate wrapped applications using DaemonWrapper, consistent with the load path, while preserving plain-class behavior.
Changes:
- Validates the class behind the
@prefix and checks its wrapper. - Adds tests for existing and missing plain and wrapped classes.
- Records the fix in the release notes.
| File | Description |
|---|---|
src/test/java/org/apache/commons/daemon/support/DaemonLoaderTest.java |
Adds plain and wrapped class validation tests. |
src/main/java/org/apache/commons/daemon/support/DaemonLoader.java |
Handles wrapped class names in check(). |
src/changes/changes.xml |
Documents the DAEMON-479 fix. |
Review effort: Balanced
Member
|
@AryanRG please rebase on git master to pick up the CodeQL fix. |
Assisted-By: Kiro (Claude Opus 5.5)
Author
|
Thanks @garydgregory. I merged current master (26ac86f) into the branch, so it now includes the CodeQL fix from #319. The PR diff is unchanged apart from the changes.xml entry, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix DAEMON-479:
jsvc -check @ClassNamerejected wrapped application classes thatDaemonLoader.load()accepts. Check the class behind the@prefix and instantiate the sameDaemonWrapperused by the load path. Plain class names retain their prior behavior.Verification
DaemonLoader.check()tests covering valid and missing plain/wrapped classes.mvn -q verifyand the defaultmvnboth passed locally.jsvcwas not built or exercised end-to-end.AI assistance used (Kiro) for code and test drafting and independent patch review.