fix: default null scientific format option to false - #1078
Open
skytin1004 wants to merge 4 commits into
Open
Conversation
skytin1004
marked this pull request as ready for review
September 8, 2026 02:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
While reviewing my formatter cache changes in #1068, I noticed a bug in the
DataFormatterconstructor when either formatting option is null.For example,
new DataFormatter(false, Locale.US, null)should use the default offalsefor scientific notation. Before this fix, formatting100000000000with theGeneralformat throws aNullPointerException. After this fix, it returns100000000000as expected.Another example is
new DataFormatter(null, Locale.US, true). Before this fix, formatting the same number returns100000000000, even though scientific notation is enabled. After this fix, it returns1E+11.The constructor was checking
use1904windowinginstead ofuseScientificFormatwhen applying the scientific-notation default. This PR changes that one condition. The examples call the constructor directly becauseNumberDataFormatterUtilsalready converts null options to their defaults after #1068.What's changed?
useScientificFormat, preserving its documented default offalse.Verification:
All 919
fesod-sheettests passed on JDK 11 with the default locale set to Korean, and the build completed successfully.Checklist