feat: support Instant string conversion - #1089
Conversation
9077a24 to
87ce5b2
Compare
|
CI on JDK 8/11 exposed a runtime compatibility difference: |
| /* | ||
| * This file is part of the Apache Fesod (Incubating) project, which was derived from Alibaba EasyExcel. | ||
| * | ||
| * Copyright (C) 2018-2024 Alibaba Group Holding Ltd. | ||
| */ |
There was a problem hiding this comment.
The newly added files in this PR are implemented from scratch and are not derived from Alibaba's EasyExcel. Therefore, no EasyExcel-related license header is required for these files.
Please refer to: https://github.com/apache/fesod/blob/main/fesod-sheet/src/main/java/org/apache/fesod/sheet/FesodSheet.java
There was a problem hiding this comment.
Updated — I removed the EasyExcel-derived header from the new converter file and retained only the ASF license header, following FesodSheet.java. The focused converter/loader tests and Spotless check pass on the updated commit 3b7ae8f.
87ce5b2 to
3b7ae8f
Compare
Purpose of the pull request
Related: #1017
Add JDK 8-compatible support for lossless conversion between
java.time.Instantand ISO-8601 Excel string cells.What's changed?
InstantStringConverterusingInstant.parse()for reads andInstant.toString()for canonical writes.Verification
mvn clean package -B -Dmaven.test.skip=false -pl fesod-common,fesod-shaded,fesod-sheetmvn -pl fesod-sheet -DskipTests spotless:checkResults after rebasing onto current
mainon JDK 21: 923 tests, 0 failures, 0 errors, 0 skipped. The generated Surefire reports include 6 passingInstantStringConverterTestcases and 5 passingDefaultConverterLoaderTestcases.Checklist