Skip to content

FINERACT-2684: Fix typo 'occured' -> 'occurred' in accounting, core and rates modules - #6391

Merged
adamsaghy merged 1 commit into
apache:developfrom
TianHengZhuang:fix-typo-occured-accounting-core-rates
Sep 9, 2026
Merged

FINERACT-2684: Fix typo 'occured' -> 'occurred' in accounting, core and rates modules#6391
adamsaghy merged 1 commit into
apache:developfrom
TianHengZhuang:fix-typo-occured-accounting-core-rates

Conversation

@TianHengZhuang

Copy link
Copy Markdown
Contributor

Pure typo fix in log messages and comments across fineract-accounting, fineract-core and fineract-rates modules. No behavioral change.

@adamsaghy

adamsaghy commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@TianHengZhuang Please make sure you are using correct PR title and commit message.
Example:
FINERACT-2684: Fix typo 'occured' -> 'occurred' in accounting, core and rates modules

Also please make sure your commit is GPG signed

@TianHengZhuang TianHengZhuang changed the title Fix typo 'occured' -> 'occurred' in accounting, core and rates modules FINERACT-2684: Fix typo 'occured' -> 'occurred' in accounting, core and rates modules Sep 4, 2026
@TianHengZhuang
TianHengZhuang force-pushed the fix-typo-occured-accounting-core-rates branch from 2e63ee4 to 4061db8 Compare September 4, 2026 23:25
@TianHengZhuang

Copy link
Copy Markdown
Contributor Author

Hi @adamsaghy, thanks for the guidance!

I've updated both the PR title and the commit message to follow the FINERACT-2684: convention. As for GPG signing, I don't currently have a GPG key configured in my environment, so the commit is unsigned. If signing is a hard requirement for this repo, please let me know and I'll see what I can do on my side.

@TianHengZhuang
TianHengZhuang force-pushed the fix-typo-occured-accounting-core-rates branch from 4061db8 to 85ae6d0 Compare September 6, 2026 02:11
@TianHengZhuang

Copy link
Copy Markdown
Contributor Author

Hi @adamsaghy, an update on this: I've now configured a GPG key and re-signed the commit in this PR. The commit message follows the FINERACT-2684: convention and GitHub now shows the signature as Verified. Thanks for your patience!

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
adamsaghy merged commit 7571630 into apache:develop Sep 9, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants