You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've updated both the PR title and the commit message to follow the FINERACT-2684: convention. As for GPG signing, I don't currently have a GPG key configured in my environment, so the commit is unsigned. If signing is a hard requirement for this repo, please let me know and I'll see what I can do on my side.
Hi @adamsaghy, an update on this: I've now configured a GPG key and re-signed the commit in this PR. The commit message follows the FINERACT-2684: convention and GitHub now shows the signature as Verified. Thanks for your patience!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure typo fix in log messages and comments under fineract-provider portfolio module. No behavioral change.