Skip to content

FINERACT-2684: Fix typo 'occured' -> 'occurred' in portfolio module - #6393

Merged
adamsaghy merged 1 commit into
apache:developfrom
TianHengZhuang:fix-typo-occured-portfolio
Sep 9, 2026
Merged

FINERACT-2684: Fix typo 'occured' -> 'occurred' in portfolio module#6393
adamsaghy merged 1 commit into
apache:developfrom
TianHengZhuang:fix-typo-occured-portfolio

Conversation

@TianHengZhuang

Copy link
Copy Markdown
Contributor

Pure typo fix in log messages and comments under fineract-provider portfolio module. No behavioral change.

@adamsaghy

Copy link
Copy Markdown
Contributor

@TianHengZhuang Please make sure you are using correct PR title and commit message.
Example:
FINERACT-2684: Fix typo 'occured' -> 'occurred' in ....

Also please make sure your commit is GPG signed

@TianHengZhuang TianHengZhuang changed the title Fix typo 'occured' -> 'occurred' in portfolio module FINERACT-2684: Fix typo 'occured' -> 'occurred' in portfolio module Sep 4, 2026
@TianHengZhuang
TianHengZhuang force-pushed the fix-typo-occured-portfolio branch from 3cbbef8 to c93f64d Compare September 4, 2026 23:25
@TianHengZhuang

Copy link
Copy Markdown
Contributor Author

Hi @adamsaghy, thanks for the guidance!

I've updated both the PR title and the commit message to follow the FINERACT-2684: convention. As for GPG signing, I don't currently have a GPG key configured in my environment, so the commit is unsigned. If signing is a hard requirement for this repo, please let me know and I'll see what I can do on my side.

@TianHengZhuang
TianHengZhuang force-pushed the fix-typo-occured-portfolio branch from c93f64d to ff604c2 Compare September 6, 2026 04:02
@TianHengZhuang

Copy link
Copy Markdown
Contributor Author

Hi @adamsaghy, an update on this: I've now configured a GPG key and re-signed the commit in this PR. The commit message follows the FINERACT-2684: convention and GitHub now shows the signature as Verified. Thanks for your patience!

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
adamsaghy merged commit 625d77c into apache:develop Sep 9, 2026
89 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants