[common] Fix negative timestamp decoding in Arrow and Iceberg - #4296
Open
fxbing wants to merge 1 commit into
Open
[common] Fix negative timestamp decoding in Arrow and Iceberg#4296fxbing wants to merge 1 commit into
fxbing wants to merge 1 commit into
Conversation
- Reuse microsecond timestamp factories and normalize Arrow nanoseconds. - Cover pre-epoch, zero, and positive Arrow and Iceberg key round trips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4295
Fix decoding failures for valid pre-epoch timestamps with sub-millisecond precision in Arrow readers and Iceberg timestamp keys.
Brief change log
TimestampNtz.fromMicros()andTimestampLtz.fromEpochMicros()for microsecond decoding.Math.floorDiv/Math.floorModfor Arrow nanoseconds, retaining constructor validation.Tests
fluss-commonreactorverify: 30 tests passed, including Checkstyle, Spotless, and license checks.API and Format
No public API or storage format changes.
Documentation
No documentation changes.
Generative AI disclosure
OpenAI Codex and Claude assisted with implementation, tests, and review.