[client] Preserve partition keys in typed deletes - #4304
Open
fxbing wants to merge 1 commit into
Open
Conversation
- Use logical primary keys when projecting and expanding typed delete rows. - Cover partitioned and nonpartitioned deletes at the WriterClient send boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #4303
Fix typed deletes on partitioned primary-key tables failing with
Partition value shouldn't be null.despite the POJO containing the partition values.Brief change log
TypedUpsertWriterImpl.WriterClient.sendto verify partitioned and nonpartitioned target paths with a null payload.Tests
API and Format
No public API, wire-protocol, or storage-format changes.
Generative AI disclosure
AI-assisted implementation and review using Claude Code and OpenAI Codex.