Skip to content

[client] Preserve partition keys in typed deletes - #4304

Open
fxbing wants to merge 1 commit into
apache:mainfrom
fxbing:fix/20260911-typed-partition-delete
Open

[client] Preserve partition keys in typed deletes#4304
fxbing wants to merge 1 commit into
apache:mainfrom
fxbing:fix/20260911-typed-partition-delete

Conversation

@fxbing

@fxbing fxbing commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Purpose

Closes #4303

Fix typed deletes on partitioned primary-key tables failing with Partition value shouldn't be null. despite the POJO containing the partition values.

Brief change log

  • Use logical primary keys for the delete projection and full-row expansion in TypedUpsertWriterImpl.
  • Add regression coverage through the real writer delegation path, capturing WriterClient.send to verify partitioned and nonpartitioned target paths with a null payload.

Tests

  • Confirmed the partitioned regression fails on the old code and both new tests pass after the fix.
  • All 51 focused and adjacent tests passed under Java 11; Spotless and Checkstyle passed.
  • Tests reused locally installed sibling SNAPSHOT artifacts. No full reactor rebuild or server-side deletion E2E was run.

API and Format

No public API, wire-protocol, or storage-format changes.

Generative AI disclosure

AI-assisted implementation and review using Claude Code and OpenAI Codex.

- Use logical primary keys when projecting and expanding typed delete rows.
- Cover partitioned and nonpartitioned deletes at the WriterClient send boundary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[client] Typed deletes drop partition keys on partitioned primary-key tables

1 participant