Fix fragment failure propagation race - #18543
Merged
JackieTien97 merged 1 commit intoAug 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShuffleSinkHandletermination with an explicit owner and completion signalRoot cause
A failed fragment can be cleaned concurrently by
DriverScheduler.forceDeregisterFragmentInstanceand the asynchronousFragmentInstanceExecutionstate listener. The first abort owns channel cleanup, while the second abort previously returnedfalseimmediately. The state listener could then close its drivers and deregister fragment memory before the first abort finished.Driver.closecould callsetNoMoreTsBlockswhileabortedwas stillfalse, sending a normal end-of-stream to the coordinator and occasionally hiding the execution error from the client. Concurrent memory deregistration also explains the observedMemoryLeakExceptionand missingRelatedMemoryReservedentries.This change makes the abort completion itself the synchronization boundary. A competing abort waits for the owner to complete, while close remains non-blocking because it may be re-entered from a channel callback that already holds a channel lock. Normal end-of-block notifications are rejected whenever termination has been claimed.
Reproduced from the flaky CI failure: https://github.com/apache/iotdb/actions/runs/33285987416/job/99189163860
Tests
mvn test -pl iotdb-core/datanode -Dtest=ShuffleSinkHandleTest -DfailIfNoTests=falsewith JDK 17IoTDBTableAggregationNonStreamIT#rateFunctionsExceptionTestunder TableClusterIT with JDK 17, four consecutive successful 1C3D runsMemoryLeakExceptionor missingRelatedMemoryReservederrors