Try Catch logic for openBatchSession - #7426
Open
oh0873 wants to merge 7 commits into
Open
Conversation
4 tasks
oh0873
force-pushed
the
hoonoh/openBatchSessionExceptionCatchv2
branch
from
June 1, 2026 13:20
7140244 to
e0a4a77
Compare
Contributor
Author
|
@pan3793 Can I get a review on this PR? |
pan3793
approved these changes
Jul 14, 2026
pan3793
reviewed
Jul 14, 2026
| } | ||
|
|
||
| override def start(): Unit = { | ||
| val UNINITIALIZED_BATCH_ID = "UNINITIALIZED_BATCH_ID" |
Member
There was a problem hiding this comment.
nit: create an object KyuubiBatchService, and move const to there
pan3793
reviewed
Jul 14, 2026
Comment on lines
+124
to
+132
| try { | ||
| metadataManager.failScheduledBatch(batchId) | ||
| } catch { | ||
| case ex: Exception => | ||
| error( | ||
| s"Unable to modify metadata for $batchId to ERROR; " + | ||
| "an administrator may need to reset the batch state manually.", | ||
| ex) | ||
| } |
Member
There was a problem hiding this comment.
consider extracting this part to a method as it repeats twice
Member
|
thanks, fix makes sense, just two style comments |
oh0873
force-pushed
the
hoonoh/openBatchSessionExceptionCatchv2
branch
from
September 8, 2026 19:27
508fc38 to
35a4a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
In Kyuubi Batch v2 version, Batch Service creates
batchExecutorto submit a batch job. However, when openBatchSession fails, the executor dies and never recovers.This results in a jobs stuck at PENDING state and no executor to submit any jobs at INITIALIZED state.
This PR added error handling logic to handle openBatchSession.
This also fixes withUpdateCount call changes fromState to targetState.
How was this patch tested?
Tested in our environment, openBatchSession exceptions like connections per user or DB connection error no longer leaves jobs stuck at PENDING state. Instead all those jobs are labeled as ERROR.
Was this patch authored or co-authored using generative AI tooling?
Test case and bug finding were assisted with Cursor agent.