Repository navigation
Clean up declared dependencies - #2246
Open
slachiewicz wants to merge 2 commits into
Open
slachiewicz wants to merge 2 commits into
slachiewicz wants to merge 2 commits into
Conversation
Removed from named-locks: mockito-core Removed from impl: guice (classes) Removed from connector-basic: guice (classes) Removed from transport-file: slf4j-api Removed from transport-jdk8: maven-resolver-util Removed from transport-jdk11: jul-to-slf4j Removed from transport-jetty: slf4j-api, maven-resolver-test-util, maven-resolver-impl Removed from transport-minio: slf4j-api, maven-resolver-test-util, maven-resolver-impl Removed from transport-url: maven-resolver-test-util Removed from generator-gnupg: bcutil-jdk18on Removed from generator-sigstore: bcpg-jdk18on, bcutil-jdk18on Removed from supplier-mvn3 and supplier-mvn4: slf4j-api Declared in transport-jetty: jetty-http, jetty-io, jetty-util, jetty-quic-client, jetty-http3-client
pilot:dependencies shows maven-resolver-impl and maven-resolver-named-locks used by the tests and jetty-quic-client unused.
gnodet-bot
approved these changes
Oct 29, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
Clean dependency hygiene: all removals verified unused via dependency:analyze and pilot bytecode analysis, all additions are correctly declared used-undeclared deps. No behavioral changes. Newly declared Jetty deps (jetty-http, jetty-io, jetty-util, jetty-http3-client) are version-managed via the Jetty BOM imported in the root POM. LGTM.
💡 Suggestion: set milestone to 2.1.0 (maintenance on the 2.x line).
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed from named-locks: mockito-core
Removed from impl: guice (classes)
Removed from connector-basic: guice (classes)
Removed from transport-file: slf4j-api
Removed from transport-jdk8: maven-resolver-util
Removed from transport-jdk11: jul-to-slf4j
Removed from transport-jetty: slf4j-api, maven-resolver-test-util
Removed from transport-minio: slf4j-api, maven-resolver-test-util, maven-resolver-impl
Removed from transport-url: maven-resolver-test-util
Removed from generator-gnupg: bcutil-jdk18on
Removed from generator-sigstore: bcpg-jdk18on, bcutil-jdk18on
Removed from supplier-mvn3 and supplier-mvn4: slf4j-api
Declared in transport-jetty: jetty-http, jetty-io, jetty-util, jetty-http3-client; maven-resolver-impl and maven-resolver-named-locks (test)
Each change was found with
dependency:analyze, cross-checked with pilot's bytecode analysis (pilot:dependencies0.5.0, which reports no unused declared or used undeclared dependency the PR introduces), and kept only with the full test suite passing.Part of apache/maven#13749.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
check one of the following: