Skip to content

Declare the Maven artifacts the code uses - #2247

Merged
slachiewicz merged 1 commit into
apache:masterfrom
slachiewicz:agent/declare-maven-deps
Oct 30, 2026
Merged

slachiewicz merged 1 commit into
apache:masterfrom
slachiewicz:agent/declare-maven-deps

Conversation

@slachiewicz

Copy link
Copy Markdown
Member

Declares the Maven, Resolver and runtime artifacts that each module's classes reference directly but used to get only transitively, so the build no longer depends on what maven-core happens to bring in (javax.inject, SLF4J and Guice reach the compile path only through maven-core 3.x's own dependencies, and maven-plugin-api 4 brings none of Sisu's). Each one was confirmed by a class reference in target/classes or target/test-classes, found with pilot's bytecode analysis.

  • maven-resolver-named-locks-hazelcast: maven-resolver-api (test).
  • maven-resolver-named-locks-ipc: maven-resolver-api (test).
  • maven-resolver-named-locks-redisson: maven-resolver-api (test).
  • maven-resolver-supplier-mvn4: maven-api-core (compile).
  • maven-resolver-test-http: maven-resolver-util (compile).
  • maven-resolver-transport-apache: junit-jupiter-params (test).
  • maven-resolver-transport-jdk11: junit-jupiter-params (test).

Part of apache/maven#13749.


To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
check one of the following:

maven-resolver-named-locks-hazelcast: maven-resolver-api (test).
maven-resolver-named-locks-ipc: maven-resolver-api (test).
maven-resolver-named-locks-redisson: maven-resolver-api (test).
maven-resolver-supplier-mvn4: maven-api-core (compile).
maven-resolver-test-http: maven-resolver-util (compile).
maven-resolver-transport-apache: junit-jupiter-params (test).
maven-resolver-transport-jdk11: junit-jupiter-params (test).
@slachiewicz
slachiewicz marked this pull request as ready for review October 29, 2026 22:16

@gnodet-bot gnodet-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Straightforward declare-what-you-use cleanup — all seven dependency additions are confirmed by direct class references, scopes are correct, and versions are properly managed (reactor BOM for resolver modules, junit-bom for JUnit, ${maven4Version} for maven-api-core). CI green across all platforms.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

@slachiewicz
slachiewicz merged commit 6c3d624 into apache:master Oct 30, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants