Repository navigation
Declare the Maven artifacts the code uses - #2247
Merged
Merged
Conversation
maven-resolver-named-locks-hazelcast: maven-resolver-api (test). maven-resolver-named-locks-ipc: maven-resolver-api (test). maven-resolver-named-locks-redisson: maven-resolver-api (test). maven-resolver-supplier-mvn4: maven-api-core (compile). maven-resolver-test-http: maven-resolver-util (compile). maven-resolver-transport-apache: junit-jupiter-params (test). maven-resolver-transport-jdk11: junit-jupiter-params (test).
gnodet-bot
approved these changes
Oct 30, 2026
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Straightforward declare-what-you-use cleanup — all seven dependency additions are confirmed by direct class references, scopes are correct, and versions are properly managed (reactor BOM for resolver modules, junit-bom for JUnit, ${maven4Version} for maven-api-core). CI green across all platforms.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declares the Maven, Resolver and runtime artifacts that each module's classes reference directly but used to get only transitively, so the build no longer depends on what maven-core happens to bring in (
javax.inject, SLF4J and Guice reach the compile path only through maven-core 3.x's own dependencies, and maven-plugin-api 4 brings none of Sisu's). Each one was confirmed by a class reference intarget/classesortarget/test-classes, found with pilot's bytecode analysis.Part of apache/maven#13749.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
check one of the following: