Skip to content

Remove redundant javaVersion and compiler release properties - #2249

Open
slachiewicz wants to merge 1 commit into
apache:masterfrom
slachiewicz:static-pom-cleanup
Open

slachiewicz wants to merge 1 commit into
apache:masterfrom
slachiewicz:static-pom-cleanup

Conversation

@slachiewicz

Copy link
Copy Markdown
Member

The parent POM already sets javaVersion to 8 and derives maven.compiler.release from it, so the effective POM is unchanged. maven.compiler.source and maven.compiler.target stay because the parent does not set them.

Part of apache/maven#13757

@slachiewicz
slachiewicz marked this pull request as ready for review October 30, 2026 06:28

@gnodet-bot gnodet-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two observations on this POM cleanup:

1. PR description is inaccurate about the inheritance chain. The description says "The parent POM already sets javaVersion to 8 and derives maven.compiler.release from it." In fact, maven-parent:50 does not define maven.compiler.release at all. It is the grandparent (apache:40) that defines it, and only conditionally via its jdk9+ profile (activated when build JDK ≥ 9). Since Maven Resolver requires JDK 11+ to build, this profile is always active in practice, so the change is functionally correct — but the description attributes the property to the wrong ancestor. Consider updating the PR description for accuracy.

2. Cosmetic: extra blank line left in maven-resolver-transport-minio/pom.xml. Removing <javaVersion>8</javaVersion> left a blank line between <properties> and <version.okhttp>. The block should be:

<properties>
  <version.okhttp>5.5.1</version.okhttp>
</properties>

This review was generated by an AI agent, Hermès on behalf of @gnodet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants