Repository navigation
Remove redundant javaVersion and compiler release properties - #2249
slachiewicz wants to merge 1 commit into
Conversation
gnodet-bot
left a comment
There was a problem hiding this comment.
Two observations on this POM cleanup:
1. PR description is inaccurate about the inheritance chain. The description says "The parent POM already sets javaVersion to 8 and derives maven.compiler.release from it." In fact, maven-parent:50 does not define maven.compiler.release at all. It is the grandparent (apache:40) that defines it, and only conditionally via its jdk9+ profile (activated when build JDK ≥ 9). Since Maven Resolver requires JDK 11+ to build, this profile is always active in practice, so the change is functionally correct — but the description attributes the property to the wrong ancestor. Consider updating the PR description for accuracy.
2. Cosmetic: extra blank line left in maven-resolver-transport-minio/pom.xml. Removing <javaVersion>8</javaVersion> left a blank line between <properties> and <version.okhttp>. The block should be:
<properties>
<version.okhttp>5.5.1</version.okhttp>
</properties>This review was generated by an AI agent, Hermès on behalf of @gnodet.
The parent POM already sets
javaVersionto 8 and derivesmaven.compiler.releasefrom it, so the effective POM is unchanged.maven.compiler.sourceandmaven.compiler.targetstay because the parent does not set them.Part of apache/maven#13757