Repository navigation
Fixed: Artifact Info graph loses or corrupts references when artifacts are loaded in parallel (OFBIZ-13772) - #2500
Merged
Conversation
…parallel ArtifactInfoFactory loads services and components on the fork-join pool, but each get*ArtifactInfo method did a get, built a new info and then a put, so two tasks could build the same artifact and the later one replaced the earlier. The reverse references were added with UtilMisc.addToSortedSetInMap, which does the same check-then-act and then adds to a plain TreeSet from many tasks at once, so a set could be replaced, losing the references already in it, or corrupted. Each info is now registered with putIfAbsent and only the registered one is populated. The reverse-reference sets are created with computeIfAbsent and, like each info's own reference sets, are ConcurrentSkipListSets, so the Artifact Info screens can also iterate them while another request loads artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArtifactInfoFactory loads services and components on the fork-join pool, but each get*ArtifactInfo method did a get, built a new info and then a put, so two tasks could build the same artifact and the later one replaced the earlier. The reverse references were added with UtilMisc.addToSortedSetInMap, which does the same check-then-act and then adds to a plain TreeSet from many tasks at once, so a set could be replaced, losing the references already in it, or corrupted.
Each info is now registered with putIfAbsent and only the registered one is populated. The reverse-reference sets are created with computeIfAbsent and, like each info's own reference sets, are ConcurrentSkipListSets, so the Artifact Info screens can also iterate them while another request loads artifacts.