Repository navigation
Fixed: Configurable product selections leak between shopping carts through the product config cache (OFBIZ-13773) - #2502
Merged
Conversation
… cache ProductConfigWorker.getProductConfigWrapper returned the cached ProductConfigWrapper itself on a cache miss, so the first customer's selections and comments were written into the cache and copied to every later visitor. It now always returns a copy. Copies were not independent either: a copied ConfigOption kept the source option's parent ConfigItem and shared its componentOptions map, so copied options now belong to the copied item and get their own map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurable product selections could leak from one customer's cart into another's, and copied cart lines were not independent of the line they were copied from: