ORC-624: [C++] Avoid unaligned trailer loads in LZO decompressor - #2709
Closed
wgtmac wants to merge 1 commit into
Closed
ORC-624: [C++] Avoid unaligned trailer loads in LZO decompressor#2709wgtmac wants to merge 1 commit into
wgtmac wants to merge 1 commit into
Conversation
Decode 16-bit LZO trailers in little-endian order without dereferencing unaligned pointers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces two potentially unaligned 16-bit trailer loads with an alignment-safe little-endian reader.
It also adds a long-distance match test covering the previously untested
0x10LZO command path. This is a focused replacement for the LZO portion of #496, which was closed without merging.Why are the changes needed?
The LZO input pointer advances byte by byte and is not guaranteed to be 2-byte aligned. Dereferencing it as
uint16_t*orint16_t*is undefined behavior and is reported by UBSan.How was this patch tested?
All four tests passed. The existing long test covers the
0x20command path, and the new test covers the0x10path.Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)