[core] Avoid retaining rejected cache pages - #9658
Open
yuzelin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#8857 changes the default Guava cache to Caffeine cache.
However, Caffeine has a feature, where a newly put value might not be admitted into the cache (see github issue).
In
BlockCache, we maintain another variableblocksand it should be synced with Caffeine cache. Due to the above feature, when new value is not admitted, this value will still be kept inblocksand consumes memory. This PR fixes the issue.This is only a temporary fix. Our goal should be removing the variable
blocksand maintain everything in cache.Tests
CacheManagerTest