Repository navigation
Remove Scoop and winget from the release process - #90
Merged
Merged
Conversation
No version was submitted to either, and none is planned. The release guide loses their sections, its target and step rows, and the Scoop condition of --remove-old. publish no longer prints them as a next step, and its --remove-old message no longer waits for a Scoop bucket. The guide keeps the rule that a package manager the project is not in yet needs the PMC's agreement first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scoop and winget leave the release process. No version was submitted to either, and none is planned.
docs/en/guides/how-to-release.mdloses the Scoop and winget sections, their rows in Release targets and The steps, and the Scoop condition in Later: remove old versions. It keeps the rule that a package manager the project is not in yet needs the PMC's agreement first, on dev@skywalking.apache.org. The conveniences it lists are now Homebrew, apt and PyPI.tools/release/release.sh:publishno longer prints the Scoop and winget step, and the--remove-oldstep after it takes its number. The message that refuses--remove-oldin the run that moves no longer names a Scoop bucket.tools/test/release-publish/publish_test.gono longer expects the step.docs/en/changes/changes.mdsays so under Release.The released 0.4.0 changelog still links the guide's old Scoop section. It is left as released.
go test ./tools/test/release-publish/...and the docs tests in./testspass.