Repository navigation
Name the Zipkin store as a GenAITraceRefType value, replacing GenAITraceStorage - #178
Merged
Merged
Conversation
…aceStorage Reverts #177. GenAITraceRefType itself now names the store holding the span an evaluation was produced from: SKYWALKING_NATIVE, OTLP for OTLP spans stored as received (receiver-otel `otlpTraceStorage: otlp`), and the new ZIPKIN for spans received by receiver-zipkin or converted from OTLP with `otlpTraceStorage: zipkin`. OTLP and Zipkin spans are both addressed by trace ID and span ID. The separate GenAITraceRef.storage field and GenAITraceStorage enum from #177 are removed; no release shipped them.
wu-sheng
added a commit
to apache/skywalking
that referenced
this pull request
Oct 19, 2026
… traceRef.type `traceRef.type` was the span's addressing scheme, so an `OTLP` reference could point into either the native OTLP store or the Zipkin store, and a client could not tell which one to read the trace from. GenAITraceRefType gains ZIPKIN, and each listener path records the store the span went to: OTLP for natively stored OTLP spans, ZIPKIN for spans received by receiver-zipkin or converted from OTLP with `otlpTraceStorage: zipkin`. The value goes into the existing `ref_type` column. The relatedTrace filters, the query validation and the evaluation span check switch on every type and reject an unknown one. The query protocol points at apache/skywalking-query-protocol#178.
This was referenced Oct 19, 2026
wu-sheng
added a commit
to apache/skywalking
that referenced
this pull request
Oct 19, 2026
… traceRef.type `traceRef.type` was the span's addressing scheme, so an `OTLP` reference could point into either the native OTLP store or the Zipkin store, and a client could not tell which one to read the trace from. GenAITraceRefType gains ZIPKIN, and each listener path records the store the span went to: OTLP for natively stored OTLP spans, ZIPKIN for spans received by receiver-zipkin or converted from OTLP with `otlpTraceStorage: zipkin`. The value goes into the existing `ref_type` column. The relatedTrace filters, the query validation and the evaluation span check switch on every type and reject an unknown one. The new mixed-virtual-genai e2e case judges spans from a SkyWalking agent, an OTLP exporter and a Zipkin exporter on one OAP, and checks that each record is found again through relatedTrace and names the only store holding its trace. The query protocol points at apache/skywalking-query-protocol#178 and #179.
wu-sheng
added a commit
to apache/skywalking
that referenced
this pull request
Oct 19, 2026
… traceRef.type (#14152) `traceRef.type` was the span's addressing scheme, so an `OTLP` reference could point into either the native OTLP store or the Zipkin store, and a client could not tell which one to read the trace from. GenAITraceRefType gains ZIPKIN, and each listener path records the store the span went to: OTLP for natively stored OTLP spans, ZIPKIN for spans received by receiver-zipkin or converted from OTLP with `otlpTraceStorage: zipkin`. The value goes into the existing `ref_type` column. The relatedTrace filters, the query validation and the evaluation span check switch on every type and reject an unknown one. The new mixed-virtual-genai e2e case judges spans from a SkyWalking agent, an OTLP exporter and a Zipkin exporter on one OAP, and checks that each record is found again through relatedTrace and names the only store holding its trace. The query protocol points at apache/skywalking-query-protocol#178 and #179.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #177. Instead of a separate
GenAITraceRef.storagefield,GenAITraceRefTypeitself now names the store holding the span an evaluation was produced from, as suggested in apache/skywalking#14152 (comment):SKYWALKING_NATIVE: SkyWalking native segments, addressed by trace + segment + segment-local span index.OTLP: OTLP spans stored as received, with receiver-otelotlpTraceStorage: otlp. Served by the TraceQL OTLP datasource.ZIPKIN(new): spans received by receiver-zipkin, or OTLP spans converted with receiver-otelotlpTraceStorage: zipkin. Served by the Zipkin query API.OTLPandZIPKINshare the trace + span id addressing, so thespanIdfields ofGenAITraceRefandGenAITraceScopeConditionnow say "OTLP and ZIPKIN only".GenAITraceStorageandGenAITraceRef.storageare removed; no release shipped them.Implementation: apache/skywalking#14152, which points its submodule at this branch.