Review and tidy solr/modules/ltr code - #4837
Open
epugh wants to merge 1 commit into
Open
Conversation
Split out from apache#4743 into a per-module PR to make review easier. Contains the tidy-up changes to solr/modules/ltr (dead-field/method removal, toString()/this interchange, isEmpty() idioms, javadoc/ comment fixes, interlavingAlgorithm -> interleavingAlgorithm field rename). One non-cosmetic fix is included: TestWrapperModel.java's testOverwrittenMethods() now skips private methods when reflecting over LTRScoringModel's declared methods. Without this, LTRScoringModel's private calculateHashCode() was being treated as overridable, incorrectly failing the test. Flagging this explicitly since it is a real bug fix riding along with the tidying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split out from #4743 into smaller, per-module PRs to make review easier. This PR contains the tidy-up changes to
solr/modules/ltr(production + test code).Solution
Leverage IntelliJ warnings (dead field/method removal,
toString()/thisinterchange,isEmpty()idioms, javadoc/comment fixes,interlavingAlgorithm→interleavingAlgorithmfield rename,TestUserTermScorereQDF→TestUserTermScorerQDFtypo-fix rename).One non-cosmetic change to flag explicitly:
TestWrapperModel.java'stestOverwrittenMethods()now skipsprivatemethods when reflecting overLTRScoringModel's declared methods. Without this,LTRScoringModel's privatecalculateHashCode()was being picked up as "overridable" and the test incorrectly demandedWrapperModeldeclare an override for it. This is a genuine test bug fix, not just tidying — calling it out here so it doesn't get missed in review.Tests
existing
Relates to #4743