feat(gui): wire the Form View entry points and turn it on

[yangzhang75]

What changes were proposed in this PR?

Closes #8028. Part of the Form View stack (parent issue #8011), on main now that #8516 and #8517 have merged. The review commit is the branch's single commit.

Wires the Form View entry points and turns the feature on.

• The dashboard opens a workflow in its default_view (form or canvas), with a toggle that persists the choice; the deep link goes to the existing /workflow/:id/form route. Both renderers of the dashboard, the list row and the card, follow one shared rule (default-view-landing.ts: mark, deep link, toggle), so switching the view mode does not lose the entry point. The toggle is offered only with WRITE access, which the endpoint requires, and the handler checks the same rule rather than trusting the template; it is a proper toggle button (constant accessible name, state in aria-pressed, the hover title spelling out what a click does); hub links are left untouched.
• The canvas menu gains the same Canvas / Form View switch the form already shows, so the two views swap in place. It saves first and hands over only once the save has completed: the switch is a full-page load, which aborts a request still in flight. Two more things the hand-over must not lose: an autosave already in flight when the switch is clicked (WorkflowPersistService now sends saves one at a time and in call order, at the one place every save goes through, so the switch's save lands and completes after it; each caller still gets only its own result and a failed save does not hold up the next), and an edit made while the switch's save is out (the page stays editable until the load; workflowChanged marks it and the hand-over saves once more before leaving). A second click while the hand-over is in progress is a no-op. A failed save keeps the user on the canvas with the error shown. Every workflow offers both views whenever the flag is on: default_view only decides the landing view, and neither view gates the other.
• Download/upload round-trips defaultView as a sibling key next to the workflow content; an old export without it imports unchanged.
• The computing unit the user picks is remembered per workflow (localStorage) so it survives switching between the two views; a unit selected on load (the remembered one, the last execution's, a running one) is derived rather than chosen and is not stored, or a derived unit would later outrank a fresher last execution. On load the remembered unit is honoured only once the unit list has arrived and still holds it: a unit that has since been terminated is forgotten and the last execution's unit is used instead, and a decision still pending when the workflow changes underneath it is dropped.
• Flips form-view-enabled to true, with the GuiConfigSpec assertion updated to match.

Any related issues, documentation, discussions?

Closes #8028. Part of the Form View feature (parent issue #8011).

How was this PR tested?

Unit tests (vitest) cover the menu's Canvas / Form View switch through the DOM (absent with the flag off, Canvas pressed, Form View handing over, hidden while an older version is displayed), the row's and the card's default-view behavior (mark and deep link, hub link untouched, flag off leaves the dashboard as today, WRITE-only toggle in the DOM, toggle on / off / failed request / no cached row), the menu switch (navigates only once the save completes, stays on the canvas with the error when it fails, saves once more when an edit lands while its save is out, ignores a second click mid hand-over), the persist service sending saves one at a time in order with each caller getting its own result and a failure not holding up the next, the dashboard toggle handlers refusing without WRITE access, the toggle's aria-pressed following the state, the export/import round-trip including a legacy file without defaultView, and the computing-unit recall (waits for the first non-empty unit list, forgets a terminated unit and falls back, drops a stale decision after the workflow changed, positive-integer validation, storage failures, only an explicit pick remembered). GuiConfigSpec asserts the flag. Each new guard was deletion-checked (removing it turns the corresponding test red). eslint, prettier and the production (AOT) build pass; every changed line, template lines included, is statement and function covered.

Video

1. Default view on the dashboard

(row and card toggle, Form View icon, deep link into the form, toggle off again, no toggle without write access)

2. Canvas / Form View switch

(save first, then the hand-over; and back)

3. Computing unit remembered across the switch

4. Download / upload keeps the default view

Was this PR authored or co-authored using generative AI tooling?

Yes. Generated-by: Claude Code (Claude Fable 5.1, Anthropic). Co-authored with Claude, reviewed line by line by the author before submission.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FVvP3ttj22f9LB4p9u2anY

[github-actions]

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

• Contributors with relevant context: @tanishqgandhi1908, @Neilk1021, @xuang7
  You can notify them by mentioning @tanishqgandhi1908, @Neilk1021, @xuang7 in a comment.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 99.37500% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.90%. Comparing base (7190a81) to head (5db7eef).

Files with missing lines	Patch %	Lines
.../component/user/list-item/list-item.component.html	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8456      +/-   ##
============================================
+ Coverage     95.88%   95.90%   +0.01%     
  Complexity      459      459              
============================================
  Files           588      589       +1     
  Lines         33802    33946     +144     
  Branches       4217     4244      +27     
============================================
+ Hits          32411    32555     +144     
  Misses          813      813              
  Partials        578      578              

Flag	Coverage Δ		*Carryforward flag
access-control-service	80.18% <ø> (ø)
agent-service	99.32% <ø> (ø)		Carriedforward from 7190a81
amber	90.82% <ø> (ø)
computing-unit-managing-service	77.14% <ø> (ø)
config-service	87.12% <ø> (ø)
file-service	83.65% <ø> (ø)		Carriedforward from 7190a81
frontend	96.72% <99.37%> (+0.02%)	⬆️
notebook-migration-service	83.73% <ø> (ø)
pyamber	98.41% <ø> (ø)		Carriedforward from 7190a81
workflow-compiling-service	74.09% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

⚠️ Benchmark changes need a look

🟢 2 better · 🔴 3 worse · ⚪ 10 noise (<±5%) · 0 without baseline

Compared against main 7190a81 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

	config	throughput	MB/s	latency	max Δ latest / 7d
🔴	bs=10 sw=10 sl=64	363	0.222	28,281/34,499/34,499 us	🔴 +12.5% / 🔴 +130.3%
🔴	bs=100 sw=10 sl=64	816	0.498	119,931/141,515/141,515 us	🔴 +8.8% / 🔴 +37.8%
⚪	bs=1000 sw=10 sl=64	907	0.554	1,099,779/1,225,814/1,225,814 us	⚪ within ±5% / 🔴 +25.1%

Baseline details

Latest main 7190a81 from same runner

config	metric	PR	latest main	7d avg	Δ latest	Δ 7d
bs=10 sw=10 sl=64	throughput	363 tuples/sec	377 tuples/sec	807.77 tuples/sec	-3.7%	-55.1%
bs=10 sw=10 sl=64	MB/s	0.222 MB/s	0.23 MB/s	0.493 MB/s	-3.5%	-55.0%
bs=10 sw=10 sl=64	p50	28,281 us	25,134 us	12,280 us	+12.5%	+130.3%
bs=10 sw=10 sl=64	p95	34,499 us	37,873 us	15,066 us	-8.9%	+129.0%
bs=10 sw=10 sl=64	p99	34,499 us	37,873 us	19,166 us	-8.9%	+80.0%
bs=100 sw=10 sl=64	throughput	816 tuples/sec	829 tuples/sec	1,054 tuples/sec	-1.6%	-22.6%
bs=100 sw=10 sl=64	MB/s	0.498 MB/s	0.506 MB/s	0.643 MB/s	-1.6%	-22.6%
bs=100 sw=10 sl=64	p50	119,931 us	120,048 us	96,023 us	-0.1%	+24.9%
bs=100 sw=10 sl=64	p95	141,515 us	130,031 us	102,660 us	+8.8%	+37.8%
bs=100 sw=10 sl=64	p99	141,515 us	130,031 us	114,950 us	+8.8%	+23.1%
bs=1000 sw=10 sl=64	throughput	907 tuples/sec	924 tuples/sec	1,086 tuples/sec	-1.8%	-16.5%
bs=1000 sw=10 sl=64	MB/s	0.554 MB/s	0.564 MB/s	0.663 MB/s	-1.8%	-16.5%
bs=1000 sw=10 sl=64	p50	1,099,779 us	1,073,687 us	940,412 us	+2.4%	+16.9%
bs=1000 sw=10 sl=64	p95	1,225,814 us	1,179,829 us	979,930 us	+3.9%	+25.1%
bs=1000 sw=10 sl=64	p99	1,225,814 us	1,179,829 us	1,015,625 us	+3.9%	+20.7%

Raw CSV

config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,550.71,200,128000,363,0.222,28281.45,34498.61,34498.61
1,100,10,64,20,2450.35,2000,1280000,816,0.498,119930.80,141514.76,141514.76
2,1000,10,64,20,22052.80,20000,12800000,907,0.554,1099779.27,1225813.77,1225813.77

[Copilot]

🟡 Changes recommended

Read-only inspection can mutate shared workflow state, while several entry-point and persistence paths remain incomplete or unreliable.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Completes the Form View rollout by adding authoring, navigation entry points, default-view persistence, and computing-unit recall.

Changes:

• Adds in-place Form View authoring and step inspection.
• Adds dashboard/menu navigation and default-view import/export.
• Enables Form View by default and remembers computing-unit selection.

File summaries

File	Description
form-binding.service.ts	Updates result-selection documentation.
workflow-form.spec-harness.ts	Expands authoring and selection mocks.
workflow-form.rendered.spec.ts	Stubs the embedded property editor.
workflow-form.component.ts	Adds inspection and authoring behavior.
workflow-form.component.spec.ts	Tests inspection and authoring.
workflow-form.component.scss	Styles inspection and authoring UI.
workflow-form.component.html	Renders authoring controls and property panel.
property-editor.component.ts	Adds placement and broadcast controls.
property-editor.component.spec.ts	Tests new property-editor controls.
operator-property-edit-frame.component.ts	Suppresses selected shared-model writes.
operator-property-edit-frame.component.spec.ts	Tests broadcast suppression.
computing-unit-selection.component.ts	Persists selections per workflow.
computing-unit-selection.component.spec.ts	Tests computing-unit recall.
menu.component.ts	Adds Canvas-to-Form navigation.
menu.component.spec.ts	Tests persistence before switching.
menu.component.scss	Styles the view switch.
menu.component.html	Renders the view switch.
download.service.ts	Exports the default view.
download.service.spec.ts	Tests exported metadata.
user-workflow.component.ts	Imports the default view.
user-workflow.component.spec.ts	Tests legacy and new imports.
list-item.component.ts	Applies and toggles landing views.
list-item.component.spec.ts	Tests default-view behavior.
list-item.component.scss	Styles form-default entries.
list-item.component.html	Adds the default-view action.
workflow-persist.service.ts	Sends default view during creation.
workflow-persist.service.spec.ts	Tests creation payloads.
formly-config.ts	Registers the editable-label wrapper.
editable-label-wrapper.component.ts	Implements editable field labels.
editable-label-wrapper.component.spec.ts	Tests label editing and hiding.
editable-label-wrapper.component.scss	Styles editable labels.
editable-label-wrapper.component.html	Renders label controls.
GuiConfigSpec.scala	Updates the enabled-default assertion.
gui.conf	Enables Form View by default.

Review details

• Files reviewed: 34/34 changed files
• Comments generated: 11
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Read-only switching, save-drain races, stale computing-unit callbacks, and canvas export round-tripping remain incorrect.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (1)

frontend/src/app/workspace/component/menu/menu.component.ts:671

• This dirty marker only observes graph/form-binding events; workflow-name edits emit workflowMetaDataChanged() instead. If the name is committed while this save is in flight, its queued save starts after this one, but this completion immediately unloads the page and can abort it; the response also temporarily overwrites the new name. Preserve and mark a name that changed after the snapshot so the hand-over performs its final save before navigating.

    // The snapshot below carries everything reported up to now.
    this.editedSinceSwitchSnapshot = false;
    this.workflowPersistService
      .persistWorkflow(this.workflowActionService.getWorkflow())

• Files reviewed: 24/24 changed files
• Comments generated: 3
• Review effort level: Balanced