chore(frontend): remove the unused DatasetVersionFileTreeManager - #8464
Open
aglinxinyuan wants to merge 1 commit into
Open
aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8464 +/- ##
=========================================
Coverage 93.94% 93.94%
Complexity 4826 4826
=========================================
Files 1209 1209
Lines 49705 49642 -63
Branches 6074 6056 -18
=========================================
- Hits 46694 46638 -56
+ Misses 1522 1521 -1
+ Partials 1489 1483 -6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes
DatasetVersionFileTreeManager, which builds a client-side hash map of dataset file paths that nothing in production constructs. Pure deletion, no behaviour change: −287 lines.History
files-uploader.component.ts(previouslyUploadFilesManager,newUploadFileTreeManager) once LakeFS began serving the file tree. The leftover dangling import was swept away by #3848 (2025-10-11, theorg.apacherename)Dead for about a year and a half.
Any related issues, documentation, discussions?
Closes #8462
How was this PR tested?
Existing tests only — this PR removes a class and the spec block that covered it.
From
frontend/:npx ng test --watch=false --include='**/datasetVersionFileTree.spec.ts'— 10 tests pass (the survivingDatasetFileNode/getFullPathFromDatasetFileNodecoverage).yarn --cwd frontend format:ci— clean.Verification, re-runnable by a reviewer:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)