Conversation
…e#8375) ### What changes were proposed in this PR? `typing-extensions` is a direct dependency, and the version it resolves to moved to 4.16.0 while `amber/LICENSE-binary-python` still claimed 4.14.1. Direct-dependency drift hard-fails the license check rather than being reported as informational, so `build / pyamber (ubuntu-latest, 3.12)` fails its license step on every pull request and on `main` — the last four `Required Checks` runs on `main` are red — and every later step in that job is skipped. Re-running does not help: the resolver picks up 4.16.0 each time. The version is the only thing that changed. PyPI reports `license_expression: PSF-2.0` for both 4.14.1 and 4.16.0, so the entry stays in the Python Software Foundation License section it is already listed under. The transitive entries printed alongside it in the same output are advisory; the nightly exact-match check on `main` refreshes those. ### Any related issues, documentation, discussions? Closes apache#8374. Same failure mode as apache#8293, with a different package. apache#7285 is the weekly aggregate tracker `license-binary-checker.yml` re-uses; it does not name the offending dependency. ### How was this PR tested? Verified before editing rather than after: the failing run is [33710669719](https://github.com/apache/texera/actions/runs/33710669719), whose license step prints `~ typing-extensions: LICENSE-binary=4.14.1 bundled=4.16.0` under `DRIFT (direct)`. PyPI's metadata for both versions reports `license_expression: PSF-2.0`, and the entry is already in the Python Software Foundation License section, so no section move is needed. The check itself runs in CI on this PR — a green `build / pyamber (ubuntu-latest, 3.12)` is the confirmation that the manifest now matches what gets installed. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-5) (cherry picked from commit 16da22b)
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The manifest matches the resolved dependency version with no unresolved issues.
Pull request overview
Updates Amber’s Python binary-license manifest to match the resolved typing-extensions version.
Changes:
- Changes
typing-extensionsfrom 4.14.1 to 4.16.0. - Preserves its existing license classification.
File summaries
| File | Description |
|---|---|
amber/LICENSE-binary-python |
Refreshes the recorded dependency version. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Backport of #8375 to
release/v1.3: a clean cherry-pick of its squash commit, no adaptations.typing-extensionsis a direct dependency and resolves to 4.16.0, while this branch'samber/LICENSE-binary-pythonstill claims 4.14.1. Direct-dependency drift hard-fails the license check, sobuild / pyamber (ubuntu-latest, 3.12)is red on this branch (run 34558321985, on #8500's merge) and thebackport (release/v1.3)check of every pyamber PR fails the same way (e.g. #8432). Re-running does not help: the resolver picks 4.16.0 each time.amber/requirements.txtandamber/operator-requirements.txton this branch are identical tomain's, and after this change the manifest is byte-identical tomain's, where the same check is green.Opened manually by the v1.3 release manager: #8375's
release/*labels were removed before it merged, so the automated backport never ran.Source: 16da22b
Any related issues, documentation, discussions?
Backport of #8375. Originally linked #8374.
How was this PR tested?
The check itself runs in CI on this PR: a green
build / pyamber (ubuntu-latest, 3.12)is the confirmation. Locally, the branch is verified to be exactly the squash commit cherry-picked ontorelease/v1.3(one file, one line), and the resultingamber/LICENSE-binary-pythonis byte-identical tomain's.Was this PR authored or co-authored using generative AI tooling?
Yes. Generated-by: Claude Code (claude-fable-5-1)