TOMEE-4715 - Inject @Resource fields of the @Application descriptor and test instances in TomEEEmbeddedApplicationRunner - #2958
Merged
Merged
Conversation
jungm
approved these changes
Sep 28, 2026
…nd test instances in TomEEEmbeddedApplicationRunner The descriptor and the test instances are not components of the deployed application, so there are no resource references for them and the fields stayed null. Container resources are now linked like AutoConfig does it: by the explicit lookup or name, otherwise by the name of the field and then by the type. An explicit lookup or name which can't be resolved is logged and the field is left untouched, no other resource is injected instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TOMEE-4715
Problem
@Resourcefields of the@Applicationdescriptor and of the test instances are not injected if the application is started viaTomEEEmbeddedApplicationRunner(@RunWithTomEEEmbedded,TomEEEmbeddedSingleRunner). They are not components of the deployed application, so there are no resource references for them. With the ApplicationComposer the same descriptor gets itsDataSource.This gets relevant with TOMEE-4707, as tests using
@EnableServices("jaxrs")need to move to TomEE embedded.Change
composerInjectlinks container resources (openejb/Resource/<id>) for@Resourcefields which are stillnullafter the CDI injection:lookup: JNDI lookup, then the container resource with that id.name: the container resource with that name.AutoConfig).An explicit
lookupornamewhich can't be resolved is logged as warning and the field staysnull, no other resource is injected instead.Limitations
@Resourcetypes (e.g.UserTransaction) are still not injected.Tests
Two new surefire executions in
tomee-embedded:single-server-resource-injection(name, lookup, unresolvable ones) andsingle-server-resource-by-type-injection. Both inject into the descriptor and the test instance and open a connection.