Repository navigation
release(aisix): 1.7.1 - #413
Conversation
Bump charts/aisix and charts/aisix-cp to version and appVersion 1.7.1. Sync charts/aisix-cp from api7/AISIX-Cloud v1.7.1 helm/aisix-cp: the deployment-mode checks (allowed values, saas requiring twoDSN and an SMTP relay, billing outside saas) move from render time to cp-api startup, NOTES.txt and the bootstrap-admin password follow the effective mode including an AISIX_CLOUD_DEPLOYMENT_MODE override in api.extraEnvVars, and the values comments describe on-premises refusing twoDSN. Public adaptations (docker.io registries, AppVersion tag default, real gateway image in NOTES.txt, the 1.5.0 legacy env default, README) are preserved.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Deployment mode and configuration validation charts/aisix-cp/templates/_helpers.tpl, charts/aisix-cp/templates/api-configmap.yaml, charts/aisix-cp/templates/NOTES.txt, charts/aisix-cp/values.yaml, charts/aisix-cp/README.md |
The chart derives an effective deployment mode using configured values and a direct AISIX_CLOUD_DEPLOYMENT_MODE value when present. It removes several Helm-time checks and identifies cp-api startup as the validation point. Notes and configuration descriptions reflect the mode and updated database-role requirements. |
Chart release metadata and examples charts/aisix-cp/Chart.yaml, charts/aisix/Chart.yaml, charts/aisix-cp/README.md, charts/aisix/README.md |
Both charts update their chart and application versions to 1.7.1. AISIX CP installation examples, the gateway image example, and version badges use the updated release version. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Other
Possibly related issues
- api7/docs#2633 — The chart documentation updates deployment-mode descriptions, but the provided changes do not establish a full terminology distinction among AISIX OSS, AISIX Enterprise, and AISIX Cloud.
- api7/docs#2575 — The chart documentation updates deployment guidance and configuration descriptions, which overlap with the issue’s documentation accuracy audit.
Merge Risk: 
d2b30
-
No merge-blocking issue was established, although SaaS startup validation remains unverified.
Pre-merge checks: 
-
Check name Status Explanation Resolution E2e Test Quality Review ❌ Blocking: The PR changes aisix-cpdeployment-mode validation and environment override behavior, but adds no E2E tests. CI only lints this chart; its install tests excludecharts/aisix-cp. The ex…Add an E2E suite that installs charts/aisix-cpwith a real PostgreSQL and cp-api, then verifies startup and the full control-plane flow for valid modes, invalid modes, missing SaaS requirements, forbidden on-premises settings, direct and …-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the AISIX 1.7.1 release, which matches the chart version and appVersion updates in the pull request. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Security Check No security issue is introduced by this pull request. The diff changes chart versions, documentation, Helm notes, and deployment-mode rendering. It does not add logging or response serialization, data… Full details: Security Check
-
Explanation
No security issue is introduced by this pull request. The diff changes chart versions, documentation, Helm notes, and deployment-mode rendering. It does not add logging or response serialization, database writes, API handlers, ownership checks, TLS settings, shared-resource operations, or secret-reference resolution. Category 1 — Sensitive data exposure: No issues found. The changed templates do not log, serialize, or return credentials. NOTES.txt prints only a kubectl command, not a password. Category 2 — Unencrypted database secrets: No issues found. The pull request adds no database model, migration, or persistence path. Category 3 — Authorization bypass: No issues found. The pull request changes no endpoint or permission check. Category 4 — Cross-resource access: No issues found. The pull request changes no resource lookup or ownership validation. Category 5 — TLS and cryptographic configuration: No issues found. The pull request changes no TLS or cryptographic behavior. Category 6 — Resource isolation: No issues found. The pull request changes no shared-resource or cascade operation. Category 7 — Secret reference resolution: No issues found. The new helper reads only the deployment-mode environment entry; existing credential fields continue to use Kubernetes Secret references. The removed Helm validation is explicitly replaced by cp-api startup validation in the changed chart configuration comments, not by a fail-open access path.
-
Full details: E2e Test Quality Review
-
Explanation
❌ Blocking: The PR changes
aisix-cpdeployment-mode validation and environment override behavior, but adds no E2E tests. CI only lints this chart; its install tests excludecharts/aisix-cp. The existing render and gateway checks do not exercise cp-api startup, database migration, SaaS/on-premises validation, orAISIX_CLOUD_DEPLOYMENT_MODEoverrides.Resolution
Add an E2E suite that installs
charts/aisix-cpwith a real PostgreSQL and cp-api, then verifies startup and the full control-plane flow for valid modes, invalid modes, missing SaaS requirements, forbidden on-premises settings, direct andvalueFromenvironment overrides, empty values, and bootstrap Secret/NOTES behavior. Run the suite in CI for this chart.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
nic-6443
left a comment
nic-6443
left a comment
There was a problem hiding this comment.
LGTM — 1.7.1 release sync; residual diff is only the preserved public adaptations.
Bumps
charts/aisixandcharts/aisix-cpto version and appVersion 1.7.1. Merging publishesaisix-1.7.1andaisix-cp-1.7.1.charts/aisix-cpis synced fromhelm/aisix-cpat the AISIX-Cloudv1.7.1tag. The deployment-mode checks (allowed values,saasrequiringtwoDSN.enabledand an SMTP relay, billing outsidesaas) no longer fail the render; cp-api checks them at startup, where it also sees env overrides. NOTES.txt and the bootstrap-admin password Secret now follow the effective mode, so anAISIX_CLOUD_DEPLOYMENT_MODEentry inapi.extraEnvVarsis honoured. ThetwoDSNandexternalDatabase.usernamedescriptions now say on-premises refusestwoDSNand needs a role that owns the database.The public adaptations are preserved:
docker.ioregistries with the tag defaulting to.Chart.AppVersion, the real gateway image in NOTES.txt, the 1.5.0AISIX_CLOUD_DP_IMAGEdefault in_legacy-env.tpl, and the public README.charts/aisixonly gets the version bump: the gateway's startup config has no new keys between 1.7.0 and 1.7.1.🤖 Generated with Claude Code
Summary by CodeRabbit