Skip to content

Impact model formula not readable in apparun #60

Closed

Description

@mabrnt

Same invalid_expr error as Issue #59 :

File "C:\\test_ic_model.py", line 20, in <module>
    impact_model = ImpactModel.from_yaml("../ic_model/impact_models/ic_model.yaml")
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\MA284853\Documents\python_proj\appabuild\.venv\Lib\site-packages\apparun\impact_model.py", line 176, in from_yaml
    return ImpactModel.from_dict(impact_model)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\MA284853\Documents\python_proj\appabuild\.venv\Lib\site-packages\apparun\impact_model.py", line 148, in from_dict
    tree=ImpactTreeNode.from_dict(impact_model["tree"]),
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\MA284853\Documents\python_proj\appabuild\.venv\Lib\site-packages\apparun\impact_tree.py", line 138, in from_dict
    node = ImpactTreeNode(
           ^^^^^^^^^^^^^^^
  File "C:\Users\MA284853\Documents\python_proj\appabuild\.venv\Lib\site-packages\pydantic\main.py", line 263, in __init__
    validated_self = self.__pydantic_validator__.validate_python(data, self_instance=self)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pydantic_core._pydantic_core.ValidationError: 1 validation error for ImpactTreeNode
models
   [type=invalid_expr, input_value={'EFV3_CLIMATE_CHANGE': '...soc_package_type_TSSOP'}, input_type=dict]

Code generated in impact model :

1.0*die_defect_density**2*die_shrink_factor**4*soc_die_area**2*(1.0*manuf_location_CN*(6/soc_die_node**0.3
          + 4) + 1.0*manuf_location_EU*(4.4/soc_die_node**0.3
          + 3.3) + 1.0*manuf_location_FR*(2.2/soc_die_node**0.3
          + 4.4) + 1.0*manuf_location_TW*(6.6/soc_die_node**0.3
          + 43.2809000325))/((1 - exp(-1*die_defect_density*die_shrink_factor**2*soc_die_area))**2*(-4.4*sqrt(2)/(sqrt(soc_die_area)*Abs(die_shrink_factor))
          + 7.7/(die_shrink_factor**2*soc_die_area)))

Activity

  1. added theissue type on Jun 5, 2026
  2. mabrnt commented on Jun 5, 2026

    @mabrnt
    CollaboratorAuthor

    To solve the issue, change: Abs -> abs

  3. linked a pull request that will close this issue(fix) correct validate_expr false positives #62on Jul 16, 2026
  4. m-prl commented on Jul 16, 2026

    @m-prl
    Collaborator

    Fixed in release 0.4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions