Repository navigation
fix: match rediscovered hubs by address - Issue #692 - #780
Merged
Merged
Conversation
andyblac
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes continued duplicate Zeroconf discovery of an already configured Wiser hub.
The existing fix matched rediscovered hubs by their configured name, including numbered Zeroconf suffixes. However, legacy entries may have a title or unique ID that no longer matches the hub’s advertised name.
This update also matches discovery against the configured:
When a matching entry is found, discovery is aborted directly instead of offering the same hub again.
Testing
Fixes once again wiser hub appear in HA #692