Repository navigation
feat(react-native-kratos)!: add native authentication lifecycle - #3
Conversation
TorinAsakura
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bda7075118
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: caf9b05c4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4206181883
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fb25e3d92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5300c0bf08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dcfa088e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6efcc3808
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05a84d16a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ee43bbca0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
TorinAsakura
changed the title
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Task
majordecision.How to test
Main scenario
toSessionafter SecureStore has returned a token. Log out, fail the first remote revocation, retry it, then release the late validation response. The known token must be revoked, local auth and storage cleared, and the late response must not authenticate it.user_sessionvalue while accepting a newer account. Migration must wait for validation; an older 401 must not delete the newer credential.Additional scenario
CI=true yarn install --immutable,yarn check --verifyandyarn workspace @atls/react-native-kratos build. Verify the package's ESM output and declarations against the current Expo 56 / React Native 0.85 / React 19 consumer dependency graph. Package compatibility does not imply adoption by the product..github/workflows/publish-image.ymlis absent from this branch and.github/workflows/publish-npm.yamlremains unchanged here. Merging must not start image publication; the Terraform-managed npm caller onmasternow uses the shared workspace release workflow.storage.write, then call logout before the write finishes. Both the prior and incoming server sessions must be revoked, local storage cleared, and a failed incoming revocation reported and retried.yarn version check,yarn release version infer --dry-runandyarn version apply --all --dry-run. The explicitmajordecision must remain authoritative and produce@atls/react-native-kratos@1.0.0without changing the version in this PR.Proof
32cc924b09d20201a1e4e99d1338a72c5d2169ac; the branch forked frommasteratb1c497fcc24b71922abfa4e4ca24f41c18c3bfc7. The image-workflow removal, Raijin update, pending-logout fix and explicit major decision are separate ordinary commits; no published history was rewritten.@atls/raijin@1.1.0and Yarn 4.18.0. The checked-in Yarn runtime matches the GitHub release asset's SHA-25670cc9cd3583ffa73a2533911d6412517d7f52b3fd2bac860ea9b868d0319d89a; lock/PnP files were regenerated. The root package declares ESM and the redundant.yarn/releases/package.jsonremains absent. The Raijin update did not change adapter source orpackages/react-native-kratos/package.json; the following fix changes the session store and its tests.HUSKY=0completed the verified package/runtime update; no hook or repository policy file changed. A normal immutable install and normal commit hooks passed afterward.@atls/code-runtimedependency, its one-line ambient type reference and the unreferenced legacyyarn-remote.mjsbundle. The root TypeScript include list now names onlypackages/**/*; regenerated lock/PnP files no longer contain code-runtime. The active Yarn runtime remains.yarn/releases/yarn.js..github/workflows/publish-image.ymlfrom this PR. The Terraform-owned checks workflow and the npm-publishing caller were not changed. The shared npm release workflow was repaired separately by Infrastructure #1594..idea/files and the obsoletelinterIgnorePatternsand TypeScript exclusion..idea/remains ignored so local IDE state cannot re-enter Git. On this head,CI=true yarn install --immutable --inline-builds,yarn check --verify(format, lint, typecheck, 27 unit cases and integration),yarn workspace @atls/react-native-kratos buildandyarn version checkpassed locally.CI=true yarn install --immutable --inline-builds,yarn check --verify(format, lint, typecheck, 27 unit cases, integration) andyarn workspace @atls/react-native-kratos buildpassed. Normal commit hooks passed. Before the explicit decision, inference suggestedminor; the committed.yarn/versions/d2aee7e8.ymlnow recordsmajor.yarn release version infer --dry-runreports no missing decisions,yarn version checkpasses, andyarn version apply --all --dry-runshows@atls/react-native-kratos@1.0.0. Yarn selects this workspace from the PR base.git diff --checkpasses for the manifest, lockfile and PnP loader; it reports 12 trailing whitespace lines inside the byte-verified publishedyarn.jsasset, which was kept intact. The GitHub Checks run passed before the release-decision commit; current-head checks are tracked on the PR.lint-stagedconfiguration. Its exact-head GitHub Checks run passed; that result is historical and is not assigned to this head..github/workflows/checks.yamlis unchanged. Its prior one-line direct override was removed in b379600. The shared check workflow'syarn check --verifydefault remains supported. Infrastructure #1594 delivered the new release workflow toatls/shared; Infrastructure #1599 delivered the caller switch: the OpenTofu apply succeeded, andatls/react-nativemastercontains the exact shared caller blob9c3c4adf. This PR does not edit CI or provider permissions.5359924081remains untouched.file:dependency was the candidate archive. That is packaging compatibility, not consumer adoption; this new head has not been reinstalled into those fixtures.baacd7f, and covered by two store tests; the fixing reply was published and the exact review thread was resolved. The user's earlier review remains preserved. iOS device verification is deferred. Package publication, product adoption, native app deployment and this PR's merge are not claimed.